The parent folder named "eclipse-plugin" is misleading :) The folder
consists of multiple plugins... The following folders are the individual
"plugins" that make up the org.apache.geronimo.feature feature.
org.apache.geronimo.core
org.apache,geronimo.ui
org.apache.geronimo.deployment.model
org.apache.geronimo.runtime.v1
(Plugins need to be bundled within a feature project to be able to be
installed using the update manager). So users will be installing the
"geronimo-feature" not the "geronimo-plugin(s)".
Inside each of the plugins folder, are the individual source folders.
You can think of each of these plugins as individual maven projects. As
far as the build file, yes, this is the next step that needs to be
worked out, to the add the build files in each of the projects if we
choose to build with maven.
Does that help?
Geir Magnusson Jr. wrote:
Also, why is the plugin code structured as it is?
/Users/geir/dev/apache/geronimo/trunk/sandbox/eclipse-plugin $ ls
org.apache.geronimo.core
org.apache.geronimo.feature org.apache.geronimo.ui
org.apache.geronimo.deployment.model org.apache.geronimo.runtime.v1
Any reason why we couldn't have a conventional structure of a source
directory and a build file and such? :)
geir
On Aug 24, 2005, at 6:38 AM, Geir Magnusson Jr. wrote:
Patches? We don't need no steenkeeng patches...
884 - please resubmit and grant ASF license
885 - I couldn't get this to apply successfully. I'm not sure why.
Most chunks failed.
888 - done
907 - failed like 885. I figured I'm doing something wrong, but
it's just not obvious.
geir
On Aug 23, 2005, at 5:34 PM, Sachin Patel wrote:
Add 907 to the list. Thanks.
Sachin Patel wrote:
Would one of the committers mind checking in the patches for
884,885, and 888? I'm making changes on source files that already
have existing pending patches in these jiras and don't want to
introduce new patches until their checked to avoid conflicts when
merging. For my knowledge, how is this handled? Are cumulative
patches easily handled? i.e What happens if i have Patch-A based
on revision 1 on File-A. Then I introduce Patch-B on File-A also
based on revision 1 (but includes changes that went into Patch
A). Since both of the patches are based on the same revision # I
would assume that only one of the patches can be applied without
errors or conflicts. What happens when the second patch is
applied since the patch is no longer based on the revision
specified in the patch file? If the second patch cannot be
applied, how is one expected to know which patch to throw out?
Thanks.
Sachin.
--
Geir Magnusson Jr +1-203-665-6437
[EMAIL PROTECTED]
