[ 
http://issues.apache.org/jira/browse/GERONIMO-1015?page=comments#action_12329662
 ] 

Aaron Mulder commented on GERONIMO-1015:
----------------------------------------

Oops.  A couple of things:
 - The point of the management API is to avoid hard coding object names
 - The log helper should to be a GBean, which is injected or looked up, to help 
with the previous point, to allow remote access, to make it appear in the 
JSR-77 space, etc.
 - It's difficult to make sense of this patch when it's combined with a 
previous 72k patch.  Granted that one wasn't applied promptly, but still, we 
need to keep separate patches separate
 - The EAR can't use Jetty as a parent.  How would it run under Tomcat only?
 - I don't care for the arguemnt formatting in WebAccessLogCriteria

Anyway, there's plenty of good stuff here too.  I'm going to take a swing at 
massaging it into form.

> Management API: Web Logging
> ---------------------------
>
>          Key: GERONIMO-1015
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1015
>      Project: Geronimo
>         Type: Improvement
>   Components: management
>     Versions: 1.0-M4
>  Environment: all
>     Reporter: Joe Bohn
>     Assignee: Aaron Mulder
>  Attachments: logging2.patch
>
> Management API for working with Web Logs and implementation for jetty 
> integrated with console.  Intergration with tomcat hopefully soon to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to