[ 
http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366966
 ] 

Anita Kulshreshtha commented on GERONIMO-1035:
----------------------------------------------

Thanks Jeff.  As noted in the first comment, this is the first step towards 
adding servlets to tomcat via GBeans. The tomcat deployer (not TMB) still adds 
the servlets and this code wraps them in GBeans. This code is sufficient for 
JSR-77. Adding servlets to tomcat via GBeans requires a major change of 
GeronimoStandardContext, other *Context and the TomcatContainer 
(createContext(..)). I am not sure if it will provide additional benefits. I 
have not come across any issues with our current implementation. There may (or 
may not) be some issues later when we try to merge the thread pools. As we 
discussed before, shutting off parsing of web.xml is not very straighforward. 
We will have to duplicate most of the functionality of ContextConfig. I would 
be happy to work on this, if you think it is needed. 
     


> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
>          Key: GERONIMO-1035
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1035
>      Project: Geronimo
>         Type: New Feature
>   Components: Tomcat
>     Versions: 1.0-M5
>  Environment: All
>     Reporter: Anita Kulshreshtha
>     Assignee: Jeff Genender
>      Fix For: 1.1
>  Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, 
> tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, 
> tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment 
> descriptor individually. This is needed by JSR-77 and for gathering tomcat 
> internal statistics.   

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to