2 things. 1. The tests in maven 1 ran in their own JVM. Here, they run in the same and thus some of the props are passed on from module to module. Eg. org.apache.geronimo.home.dir and org.apache.geronimo.server.dir. These props are set in the BasicServerInfo. The derby and directory tests failed b'coz it carried over these props from the transaction tests. The patches I submitted resets these 2 props. It works but only for those 2 modules. The alternative is to play safe for all modules. The surefire plugin has a forkMode option that can be set "pertest". The cons of this would be, having to setup/shutdown a JVM per test <forkMode>once | pertest</forkMode> http://maven.apache.org/plugins/maven-surefire-plugin/howto.html Comments ? What should we do ?
2. I hope we are all pruning the dependency list in the pom.xml to get rid of all those 3rd part dependencies. Just wanted to call that out and remind ourselves again. Also, I have seen some migrated POMs that have commented lines that say, "used during test only", "used by compile only". These dependencies should have the scope element set appropriately. Cheers Prasad On 3/10/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: > Jacek, I don't know if you renamed the subtasks headings under G-851 > to begin with "Migration to Maven 2: <module>" format. But I like it. > Can I do the same for the older subtasks too that have been left as is > ? It's a lot to easier to find them now. > > Cheers > Prasad > > On 3/10/06, Jacek Laskowski <[EMAIL PROTECTED]> wrote: > > 2006/3/9, Henri Yandell <[EMAIL PROTECTED]>: > > > > > The geronimo-spec-j2ee-deployment module was giving errors; but I > > > realised I was building under JDK 1.5. It works fine under 1.4; so > > > something for the future there perhaps. > > > > I think I've seen a way to make sure that M2 is used on Java 1.4. > > Can't remember what it was, though. Will need to take a look at > > Brett's reponse. > > > > ...after awhile > > > > Got it. > > > > <prerequisites> > > <maven>2.0.3-SNAPSHOT</maven> > > </prerequisites> > > > > Now, there might be a way to leverage it and ensure Java 1.4 runtime. > > > > > Next I get errors from the Geronimo :: Directory module; this is > > > because I'm being a aggressive and turning off the snapshot > > > repositories in the top pom. directory-asn1 depends on commons-test, > > > which is unreleased. In this case the ideal solution is to set > > > commons-test to test scope so it doesn't end up in the build - I'll > > > work on getting that changed - or just having them not depend on > > > commons-test :) > > > > Great. I'm looking forward to committing your patch ;) > > > > > Hen > > > > Jacek > > > > -- > > Jacek Laskowski > > http://www.laskowski.org.pl > > >
