The spirit of the patch is great. I haven't had the time to review it
in detail. So I think that's a +0?
Thanks,
Aaron
On 6/8/06, Hiram Chirino <[EMAIL PROTECTED]> wrote:
So in terms the of the RTC process, is this RTC patch dead since it
did not get the 3 +1's
I kinda would have preferred to get some -1's instead of not getting
any comments on the patch. Is it that there are not enough folks that
are interested in the activemq integration aspects of geronimo?
Regards,
Hiram
On 6/6/06, Hiram Chirino <[EMAIL PROTECTED]> wrote:
> m2 poms are included in the patch. But for some reason the current m2
> build does not seem to let you run mvn from a submodule, some
> dependency variables do not get evaluated. weird.
>
> On 6/5/06, David Jencks <[EMAIL PROTECTED]> wrote:
> >
> > On Jun 5, 2006, at 4:19 PM, Hiram Chirino wrote:
> >
> > > Howdy folks,
> > >
> > > Here's a patch that brings in the activemq gbean modules into
> > > geronimo. It's partly what was in activemq 4.x and integrated into
> > > geronimo 1.2-dead merged with the changes in the 3.x branch.
> > >
> > > It compiles at least and looks like a reasonable start. Once further
> > > integration work gets done we may need to tweak a little more. here's
> > > my +1 got get this committed. I guess I just need 3 more.
> > >
> >
> > I'd find it a lot easier to review, apply, and test this patch if you
> > attached it to a jira entry.
> >
> > Is there any chance of you coming up with a pom.xml for the m2 build?
> >
> > thanks
> > david jencks
> >
> >
>
>
> --
> Regards,
> Hiram
>
--
Regards,
Hiram
