On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote:
This is why I want to make this "the preferred build" so that
everyone uses it and find theses issues.
Oh, I thought that's why you wanted everyone to test it before it
becomes the preferred build. :)
In this case "src/conf/geronimo-plugin.xml" just needs to get
included as "META-INF/geronimo-plugin.xml" in the CAR?
Yes, and it needs variable substitution for the current module's
group/artifact/version/type. If it turns out to be hard to get this
file in as part of the CAR-building process, we can slam it in the CAR
after it's built if necessary -- it just has to get in there somehow.
(I'm also not wedded to src/conf as the preferred location, but
whatever.)
Thanks,
Aaron
On Jul 24, 2006, at 2:39 PM, Aaron Mulder wrote:
> -1 to making this "the preferred build" -- we've lost the
> functionality to build plugins as part of the build.
>
> For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml
>
> Then look at configs/welcome-jetty/target/welcome-jetty-1.2-
> SNAPSHOT.car
> and note that it doesn't have an entry for
> META-INF/geronimo-plugin.xml (whereas
> ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it).
>
> I was tipped off by Prasad's comment on another thread that the
> geronimoPlugin option to the Maven car plugin is ignored.
>
> In the M1 packaging plugin, we attached a pre or post hook to copy the
> plugin metadata file into the exploded CAR directory before zipping it
> into the Maven repository. I suspect that's not the appropriate
> approach for Maven 2, but we need something.
>
> Thanks,
> Aaron
>
> On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote:
>> FYI, I just created a new RTC for Genesis:
>>
>> http://issues.apache.org/jira/browse/GERONIMO-2223
>>
>> --jason
>>
>>
>> On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote:
>>
>> > Hi Jason,
>> > My family was visiting. I have been busy and in and out of
>> town. I
>> > am catching up on my mail and apologize for not responding to
>> all the
>> > mail promptly.
>> >
>> > I looked at the code and saw this in the top level pom :
>> > <parent>
>> > <groupId>org.apache.geronimo.genesis.config</groupId>
>> > <artifactId>project-config</artifactId>
>> > <version>1.0.0-SNAPSHOT</version>
>> > </parent>
>> > Since this project is not in the code being reviewed, I
>> commented it
>> > out and ran one 'simple mvn install' from the top directory! And
>> you
>> > know what happened...
>> >
>> > If I am a windows user who does not care to install cygwin, I
>> had to
>> > type the following :
>> > mvn -Dstage=bootstrap
>> > cd openejb2
>> > mvn -Dmaven.test.skip=true install
>> > cd ..
>> > mvn -Dstage=assemble
>> > This looked very familiar..
>> >
>> > I tried to see where o.a.g.genesis.config was being built. I found
>> > that
>> > the genesis branch has been built and published to a repo. The code
>> > under review will not work without building the code in genesis.
>> Could
>> > you please tell us which repo the artifacts built by genesis
>> have been
>> > published to?
>> > I am still going through the code and will provide more
>> feedback,
>> > even though it does not carry any weight.
>> >
>> > Cheers
>> > Anita
>> >
>> > --- Jason Dillon <[EMAIL PROTECTED]> wrote:
>> >
>> >> Please see this issue for details:
>> >>
>> >> http://issues.apache.org/jira/browse/GERONIMO-2219
>> >>
>> >> * * *
>> >>
>> >> I hope to be able to merge this work to trunk in a week or so, so
>> >> please, please, please take some time to review the branch and
>> vote
>> >> (PMC or not).
>> >>
>> >> --jason
>> >>
>> >
>> >
>> > __________________________________________________
>> > Do You Yahoo!?
>> > Tired of spam? Yahoo! Mail has the best spam protection around
>> > http://mail.yahoo.com
>>
>>
