First, I am more concerned about how the configs that are in our tree, and how they are working. It looks to me like geronimo- plugin.xml is getting put into META-INF/geronimo-plugin.xml for all car's that have one defined.

Can you please verify the functionality for trunk first.

So, exactly which bits of welcome-jetty/pom.xml did you copy? Just the plugin bits... the resources bits or the whole enchilada?

The car plugin will generate a car that includes:

target/repository/<groupId>/<artifactId>/<version>/<artifactId>- <version>.car/**

and:

    target/classes/**

 * * *

Anyways, start out with a clean build on svn up'd tree w/no C markers on svn status and then I can help you work out what is going on... cause it does sound like you have some stale bits floating around.

You should not be seeing any TransactionContextManager muck anymore... and the gbean-deployer's pom.xml was changed from <boot>true</boot> to <bootstrap>true</bootstrap> which i you did not have a updated car plugin would cause it to use a builder shell instead of a bootstrap. `mvn -X` should produce logging to show which shell type was actually used.

--jason


On Aug 12, 2006, at 8:20 AM, Aaron Mulder wrote:

OK, well, it doesn't seem to be working.

What I see when I got through the dependency problems and ran this on
my own plugin build is that the geronimo-plugin.xml gets written to
target/classes/META-INF/geronimo-plugin.xml but not
target/repository/.../META-INF/geronimo-plugin.xml and as a result the
CAR that's built does not include the geronimo-plugin.xml file.  I
copied the usage from trunk/configs/welcome-jetty/pom.xml.

Any suggestions?

Thanks,
    Aaron

On 8/12/06, Jason Dillon <[EMAIL PROTECTED]> wrote:
I've just finished committing changes that should (I hope) bring back
the functionality needed to include geronimo-plugin.xml... someone
please validate that it works as desired.

Maven is now responsible for making the car archives now... the car
plugin will always spit out into a local repo and then the
PackageMojo will create an archive out of it using the m2 archiver
bits, which allows flexible manifest entries... blah blah.

geronimo-plugin.xml is still being filtered using the resources
plugin... and really anything you drop into src/main/resources will
be included into the car, and filtering is controlled by the default
m2 bits in your pom.

Plan files have been updated to use ${pom.version} instead of $
{pom.currentVersion}... ${pom} is actually the project reference,
which is closer to what it would be if filtered by resources (which
we will eventually get to, and drop velocity).

Car files now all have LICENSE.txt and NOTICE.txt included (side-
effect of using Maven's mech to pick up resources), blah blah

The addition of the startup-jar is no longer hidden... its just
another resources in src/main/resources.

I also updated the PackageBuilder to take a list of classpath
elements (that are artifacts, like the dependency plugin) which
allows for customization of the prefix added to the entry in the
manifest, which was needed to get lib/endorsed bits (the m2 archiver
only allows one prefix per set).  Right now the list is non-
transitive... I could not figure how to get that working... need to
ping the peeps in #maven for help.  I will be pruning the list of
properties we have in the root pom to manage versions, which are
mostly unused now.

There is still some more dependency clean up that needs to be done,
but the servers are starting fine.

Please take a moment and check for any strangeness and lemme know if
you find anything.

May still be a bit more work to get the multiple car muck working...
but until I have something that is actually using the plugin that I
can peek at I can't really fix it.

I left the Deployer code asis... though my hunch is that some of this
is not needed (the jar and manifest bits primarily)... and if someone
knows if we use those bits anywhere else please speak up, else we
should drop the unused bits.

--jason




Reply via email to