[ 
http://issues.apache.org/jira/browse/GERONIMO-2382?page=comments#action_12433477
 ] 
            
Paul McMahan commented on GERONIMO-2382:
----------------------------------------

Comments on the patch:
The fields that are checked for being numeric should also be checked for being 
non-empty.  Otherwise the portlet throws an exception when trying to save if 
they are emptyl.
Using the internal form names instead of the display names seems ok in these 
portlet since the internal name is just the concatenated form of the display 
name :-)

> Webservers portlet - Form field validation using javascript
> -----------------------------------------------------------
>
>                 Key: GERONIMO-2382
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2382
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 1.1.1
>         Environment: WinXP, G 1.1.1-rc1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.1.2, 1.1.x, 1.2
>
>         Attachments: GERONIMO-2382.patch
>
>
> Form field validation in DB Manager portlet using javascript.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to