[ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528079
 ] 

Vamsavardhana Reddy commented on GERONIMO-2964:
-----------------------------------------------

I have attached three patches this time:

1.  GERONIMO-2964-2.0.patch:  Solves the problem without any constructor or 
method changes that come in the way of backward compatibility of plugins and to 
be used on branches\2.0
2.  GERONIMO-2964-2.0-w-cons-change.patch:  Solves the problem without worrying 
about anything breaking backward compatibility of plugins as something else 
seem to break it anyways and also servlet-examples, jsp-examples plugins from 
2.0.1 won't run because of the default-subject in the plan.  What other plugins 
do I need to worry about?
3.  GERONIMO-2964-trunk.patch:  It is essentially (2) above but I had to create 
a new one coz (2) won't apply neatly on trunk.

Here is what these patches solve.
They provide for a "work-dir" tag in web app plans.  If the tag is omitted, the 
behaviour is as it currently exists.  If the tag is specified (with value 
'myworkdir' say), in G/Tomcat, var/catalina/myworkdir will be used as the work 
dir for the app and in G/Jetty var/jetty/myworkdir will be used.

What's new from the previous patches:
1.  David Jencks objected to using "jetty.home" system property.  So, it is no 
longer used.
2.  David Jencks suggested changing geronimo-web-2.0.xsd and     

> Cannot specify the Tomcat work directory for a web application
> --------------------------------------------------------------
>
>                 Key: GERONIMO-2964
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2964
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Tomcat
>    Affects Versions: 1.2, 2.0-M5
>            Reporter: Aman Nanner
>            Assignee: Vamsavardhana Reddy
>            Priority: Minor
>             Fix For: 2.0.2, 2.0.x, 2.1
>
>         Attachments: g2964.war, GERONIMO-2964-2.0-w-cons-change.patch, 
> GERONIMO-2964-2.0.patch, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964-trunk.patch, GERONIMO-2964.patch, 
> suid.patch, tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/<web-app>.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to