[ https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540888 ]
Joe Bohn commented on GERONIMO-3586: ------------------------------------ This probably isn't worth the effort to argue further. We're just going around in circles. Just to clarify ... the monitoring console (by this I mean just the UI) does not need the container specific stats classes (and I didn't intend to imply that it did). It is the server code (what I called the monitoring client earlier) that needs the container specific stats classes. I still don't see a situation where the server would require both the tomcat and jetty stats classes since it will always be working with a specific server/container. Yes, splitting these would require 2 versions of the server. We already require 2 versions of the UI code because of the need to run in each container (just as there are 2 plugins for the web console itself). I'm not thrilled with the proposed organization but I won't lose any sleep over it either. I'll cancel GERONIMO-3587. > monitoring plugin: collecting agent should have separate jetty and tomcat > plugins > --------------------------------------------------------------------------------- > > Key: GERONIMO-3586 > URL: https://issues.apache.org/jira/browse/GERONIMO-3586 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring > Affects Versions: 2.1 > Environment: windows > Reporter: Viet Hung Nguyen > Assignee: Jarek Gawor > Attachments: geronimo-3586.patch > > > The collecting agent plugin needs to have separate jetty and tomcat plugins > in order to accommodate for the differences in container specific > dependencies on stats implementation (.e.g JettyContainerStatsImpl and > JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not > a problem; however, as a plugin, it is more tied down to having to specify > all dependencies in the plugin's classpath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.