[ 
https://issues.apache.org/jira/browse/GERONIMO-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540915
 ] 

Prasad Kashyap commented on GERONIMO-3586:
------------------------------------------

This is a delicate fine line.  I think I understand Anita's pov that monitoring 
and management does not pull down container-specific anything and hence the 
code can co-exist in a single plugin. However the fact remains that container 
specific code has to be executed at runtime to make this work.  Case in point, 
Jetty*Stats and Jetty*StatsImpl.

Now, we have sorta established an unwritten convention where we have (tried to) 
split the container-specific code into their own plugins for all scopes, 
compile and/or runtime. With other related work items we are very close to   
creating a flexible server with a very small footprint. A server can now be 
really tailor-made to every individual user/server instance. So in light of 
this, it makes sense to split the container specific code into their own 
plugins to avoid dead-weight. 

Or, maybe I'm still not getting what Anita is trying to convey .

> monitoring plugin: collecting agent should have separate jetty and tomcat 
> plugins
> ---------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3586
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3586
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: monitoring
>    Affects Versions: 2.1
>         Environment: windows
>            Reporter: Viet Hung Nguyen
>            Assignee: Jarek Gawor
>         Attachments: geronimo-3586.patch
>
>
> The collecting agent plugin needs to have separate jetty and tomcat plugins 
> in order to accommodate for the differences in container specific 
> dependencies on stats implementation (.e.g JettyContainerStatsImpl and 
> JettyConnectorStatsImpl). When the collecting agent was an EAR, this was not 
> a problem; however, as a plugin, it is more tied down to having to specify 
> all dependencies in the plugin's classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to