[ 
https://issues.apache.org/jira/browse/GERONIMO-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580059#action_12580059
 ] 

Jason Warner commented on GERONIMO-3902:
----------------------------------------

Joe,

I just did a quick scan through the rest of the commands and it looks like 
StartClientCommand.java uses it in the same manner  that 
StartServerCommand.java does.  I suggest that this change be made to that file 
as well and will post a patch shortly for that.  

In regards to checking individual options, I agree that that is an ideal 
approach but the same effect can also be accomplished within the rc.d groovy 
file if a user chose to do so, and I wanted to make as few changes as possible 
to the command groovy files.

> start-server, default.groovy in etc/rc.d overrides -Xmx value when starting 
> server using gshell
> -----------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3902
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3902
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jason Warner
>            Assignee: Jason Warner
>             Fix For: 2.1.1, 2.2
>
>         Attachments: Geronimo-3902.patch
>
>
> The start-server, default.groovy file is included in etc/rc.d directory and 
> contains a command to set the max heap size for geronimo when starting 
> through gshell.  This file overrides any max heap size values that are set 
> via the command line causing issues when starting the server with non-default 
> max heap values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to