Hey John, For weld/owb thing: did we investigated a maven plugin or extension autoconfiguring surefire executions with sets of dependencies per implementation configured in the plugin? Can be easier and avoid to mess up the pom/dependencies and also allows to execute both at the same time (during a release for instance ;))
Le 4 juil. 2017 02:37, "John D. Ament" <[email protected]> a écrit : On Mon, Jul 3, 2017 at 7:01 PM John D. Ament <[email protected]> wrote: > On Mon, Jul 3, 2017 at 6:39 PM Romain Manni-Bucau <[email protected]> > wrote: > >> >> >> Le 4 juil. 2017 00:01, "John D. Ament" <[email protected]> a écrit : >> >> All, >> >> I noticed a couple of things with running Geronimo Config locally. >> >> - If I build from source (the MP config repo) and then build Geronimo >> Config its all good. However, when the JAR is downloaded via the maven >> repo, I get errors like this: >> >> arquillianBeforeTest(org.eclipse.microprofile.config.tck.ConverterTest) Time >> elapsed: 0.003 sec <<< FAILURE! >> >> java.lang.RuntimeException: Could not inject members >> >> Caused by: org.apache.webbeans.exception.ProxyGenerationException: >> java.lang.SecurityException: class "org.eclipse.microprofile. >> config.Config$$OwbNormalScopeProxy0"'s signer information does not match >> signer information of other classes in the same package >> >> Caused by: java.lang.SecurityException: class "org.eclipse.microprofile. >> config.Config$$OwbNormalScopeProxy0"'s signer information does not match >> signer information of other classes in the same package >> >> I suspect its because security manager is enabled and the OWB proxies are >> ending up in the same package as the Eclipse classes. Of course it could >> have been a temporary thing as I had a local cached build. >> >> >> - There's no Jenkins job. Would anyone be against adding a Jenkins job? >> >> >> >> +1 >> > Turns out there was a Jenkins job, just not on the Geronimo view. Its there now. > >> - There's only tests for OWB. Would anyone be against adding tests for >> Weld? >> >> >> >> +0 while it stays simple (not the same hierarchy DS has for instance but >> think it is doable) >> > > > I was hoping it could be as simple as https://github.com/hammock- > project/hammock-fault-tolerance/blob/master/pom.xml#L81-L165 (which > itself is a WIP, and not working 100%) > > >> >> - There's still one failing TCK assertion, >> >> >> Tests run: 36, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.584 >> sec <<< FAILURE! - in TestSuite >> >> can_inject_simple_values_when_defined(org.eclipse. >> microprofile.config.tck.CDIPlainInjectionTest) Time elapsed: 0.023 sec >> <<< FAILURE! >> >> java.lang.NumberFormatException: For input string: >> "org.eclipse.microprofile.config.configproperty.unconfigureddvalue" >> >> at org.eclipse.microprofile.config.tck.CDIPlainInjectionTest. >> getBeanOfType(CDIPlainInjectionTest.java:110) >> >> at org.eclipse.microprofile.config.tck.CDIPlainInjectionTest.can_ >> inject_simple_values_when_defined(CDIPlainInjectionTest.java:67) >> >> >> > > I dug into this one a bit more. The ServiceLoader mechanism is choking on > the inner class for the config source. It doesn't find it even though it's > there as a service provider. The TCK test is a little weird. I'm inclined > to say the TCK should be changed, as reaching into a public static class > across the JARs is a bit weird. > > Ok, I got this one working. Turns out it was more issues with handling of default values. At least locally now the TCK passes 100%. However, Jenkins fails because of the issue I noted above.
