I don't think its a good idea to move TomEE code into Geronimo. On Fri, Mar 9, 2018 at 5:50 AM Romain Manni-Bucau <rmannibu...@gmail.com> wrote:
> If there is no other comment, any objection to move it to > geronimo-jwt-auth? (let say if not we do it on monday european time) > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > 2018-03-06 11:11 GMT+01:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > >> >> 2018-03-06 10:24 GMT+01:00 Jean-Louis Monteiro <jlmonte...@tomitribe.com> >> : >> >>> Hi community, >>> >>> >>> So we now have something close in terms of MP-JWT implementation. >>> >>> With the playground branch I've been working on (Thanks Romain for the >>> help), we now pass 100% of the TCK (including a missing part in MP-JWT >>> TCK >>> I have eagerly added - see ticket on MP-JWT). >>> >>> Now the question is how do we proceed? >>> Knowing that most of the code is not TomEE specific. >>> >> >> I'd move it to G to a new git repo keeping only the tck exec - a bit like >> Roberto started with config. I'll be happy to help fixing the small >> remaining enhancements to do (jwt parsing based on jsonb/p, config etc). >> >> >>> >>> Only few things are in the TomcatSecurityService but that can remain in >>> TomEE because it's not really MP-JWT specific either. >>> >> >> +1, was overdue anyway for our servlet-ejb integration >> >> >>> >>> Here is the PR for discussion >>> https://github.com/apache/tomee/pull/123 >>> >>> Cheers >>> Jean-Louis >>> >>> >>> -- >>> Jean-Louis Monteiro >>> http://twitter.com/jlouismonteiro >>> http://www.tomitribe.com >>> >> >> >