quick heads up: if no objection in between I plan to start creating the project tomorrow to let JL importing the code he did.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> 2018-03-12 16:33 GMT+01:00 Rudy De Busscher <rdebussc...@gmail.com>: > OK (non-binding of course :) for generic classes at Geronimo. > > On 12 March 2018 at 16:01, Jean-Louis Monteiro <jlmonte...@tomitribe.com> > wrote: > > > So what's the conclusion here? > > > > Should I request a git repo on geronimo and extract all generic classes > > there along side with other implementations? > > Or do you guys prefer another tomee repo with the MP-JWT impl? > > > > I don't mind if they go here and there, just need to know so I can move > on > > with the contribution. > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > On Fri, Mar 9, 2018 at 2:15 PM, Romain Manni-Bucau < > rmannibu...@gmail.com> > > wrote: > > > > > 2018-03-09 12:37 GMT+01:00 Jonathan Gallimore < > > > jonathan.gallim...@gmail.com> > > > : > > > > > > > Currently this in a PR, so it hasn't actually been merged anywhere. > > > There's > > > > some at least some TomEE specific code, so some modules need defining > > > > before it can be "moved" in my view. > > > > > > > > Rudy's point is good one - no doubt a generic, reusable module may > well > > > be > > > > what we end up with. Wherever that lives when it has clearly been > > > defined, > > > > it needs documenting and showing how to use it. > > > > > > > > We talked previously about being able to have modules in separate > repos > > > > under TomEE. Is there some issue with doing that? What's the rush to > > > shift > > > > this off to Geronimo? > > > > > > > > > > No rush, geronimo will have a jwt-auth impl and I was waiting JL push > > what > > > he did before speaking of creating a project @G. I would like to share > > the > > > same impl with tomee to avoid to x2 the effort. however if not desired > it > > > is fine as well. > > > > > > It is also important to keep in mind that on tomee side there is *no* > > > specific code, only fixes in the propagation which also impact > > webprofile, > > > nothing linked to MP or this particular spec. > > > > > > > > > > > > > > > > > Jon > > > > > > > > On Fri, Mar 9, 2018 at 11:27 AM, Rudy De Busscher < > > rdebussc...@gmail.com > > > > > > > > wrote: > > > > > > > > > I'm not saying we should move TomEE code into Geronimo. > > > > > > > > > > If we move the generic stuff for JWT Auth to Geronimo, it will not > be > > > > > enough to have it completely functional. And that should be made > > clear > > > > from > > > > > the beginning for all potential usages. > > > > > > > > > > On 9 March 2018 at 12:20, John D. Ament <johndam...@apache.org> > > wrote: > > > > > > > > > > > I don't think its a good idea to move TomEE code into Geronimo. > > > > > > > > > > > > On Fri, Mar 9, 2018 at 5:50 AM Romain Manni-Bucau < > > > > rmannibu...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > If there is no other comment, any objection to move it to > > > > > > > geronimo-jwt-auth? (let say if not we do it on monday european > > > time) > > > > > > > > > > > > > > > > > > > > > Romain Manni-Bucau > > > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > > > > > <http://rmannibucau.wordpress.com> | Github > > > > > > > <https://github.com/rmannibucau> | LinkedIn > > > > > > > <https://www.linkedin.com/in/rmannibucau> | Book > > > > > > > <https://www.packtpub.com/application-development/java- > > > > > > ee-8-high-performance> > > > > > > > > > > > > > > 2018-03-06 11:11 GMT+01:00 Romain Manni-Bucau < > > > rmannibu...@gmail.com > > > > >: > > > > > > > > > > > > > >> > > > > > > >> 2018-03-06 10:24 GMT+01:00 Jean-Louis Monteiro < > > > > > > jlmonte...@tomitribe.com> > > > > > > >> : > > > > > > >> > > > > > > >>> Hi community, > > > > > > >>> > > > > > > >>> > > > > > > >>> So we now have something close in terms of MP-JWT > > implementation. > > > > > > >>> > > > > > > >>> With the playground branch I've been working on (Thanks > Romain > > > for > > > > > the > > > > > > >>> help), we now pass 100% of the TCK (including a missing part > in > > > > > MP-JWT > > > > > > >>> TCK > > > > > > >>> I have eagerly added - see ticket on MP-JWT). > > > > > > >>> > > > > > > >>> Now the question is how do we proceed? > > > > > > >>> Knowing that most of the code is not TomEE specific. > > > > > > >>> > > > > > > >> > > > > > > >> I'd move it to G to a new git repo keeping only the tck exec > - a > > > bit > > > > > > like > > > > > > >> Roberto started with config. I'll be happy to help fixing the > > > small > > > > > > >> remaining enhancements to do (jwt parsing based on jsonb/p, > > config > > > > > etc). > > > > > > >> > > > > > > >> > > > > > > >>> > > > > > > >>> Only few things are in the TomcatSecurityService but that can > > > > remain > > > > > in > > > > > > >>> TomEE because it's not really MP-JWT specific either. > > > > > > >>> > > > > > > >> > > > > > > >> +1, was overdue anyway for our servlet-ejb integration > > > > > > >> > > > > > > >> > > > > > > >>> > > > > > > >>> Here is the PR for discussion > > > > > > >>> https://github.com/apache/tomee/pull/123 > > > > > > >>> > > > > > > >>> Cheers > > > > > > >>> Jean-Louis > > > > > > >>> > > > > > > >>> > > > > > > >>> -- > > > > > > >>> Jean-Louis Monteiro > > > > > > >>> http://twitter.com/jlouismonteiro > > > > > > >>> http://www.tomitribe.com > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > >
