That sounds like good improvements. Thanks for the visibility. And also 5.x sounds better considering the changes and the removal of some converters.
Le jeu. 9 août 2018 à 09:37, Romain Manni-Bucau <[email protected]> a écrit : > pushed > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le jeu. 9 août 2018 à 07:42, Romain Manni-Bucau <[email protected]> a > écrit : > >> If we go 5 we should probably drop the static PropertiesEditors class >> which leads to trivial leakages in all servers and do a registry apps >> instantiate at need with closeable support for editors. I can push that >> today if there is no objection. >> >> It would also ensure we can cache the reflection needed for the jaxrs >> style you added a enable the blueprint version upgrade directlt. >> >> +1 from me to go that path at once >> >> Le jeu. 9 août 2018 03:54, David Blevins <[email protected]> a >> écrit : >> >>> All, >>> >>> I updated the converter code in xbean-reflect to add support for JAX-RS >>> style string constructors and static factory methods. We weren't so clever >>> to think of this in 2006, but it definitely fits. >>> >>> Moreover, I don't think we need half of the built-in >>> Converter/PropertyEditor implementations now. Most of them can be deleted >>> with likely a positive speed impact as part of the process of converting is >>> looping over all the built-in Converter/PropertyEditor instances. There's >>> a second startup improvement as well as they are created eagerly via static >>> initializer. >>> >>> I'd love to do a 4.x release of this code. It could be nice to save the >>> deleting of the property editors for a potential XBean 5.x. I'm ok with >>> one or the other or both. I see Łukasz's work which might make for a good >>> 5.x release, so maybe we just do that. >>> >>> Thoughts or preferences? >>> >>> >>> -David >>> >>>
