Hi Ivan Indeed it does but fix was quite straight forward and i was planning a release on sunday - but got some "box" issues on saturday and a good part of sunday so i didnt manage to make it. Rational was to include it in microprofile repo release. If I can I will proceed later this week.
On the process Im fine with whatever works the best and doesnt slow down too much dependencies. Guess the fixes we got last week - and why mp repo must be rereleased - + the fact it happens over a weekend for you was a no luck case here. Also being more vocal on the dev list can help since we are list driven and not github driven - just thinking out loud. At least it would have enabled to 1. know you were going to work on that and 2. guide you earlier and avoid to ask you to rework the pr probably. Wdyt? Romain Le mar. 8 janv. 2019 18:56, Ivan Junckes Filho <[email protected]> a écrit : > Hey Romain, I see your comments with feedback in the PR I opened, thank > you for that. I had a busy weekend and couldn't reply immediately. > https://github.com/apache/geronimo-openapi/pull/4 > > But I saw also in the PR that there were some conflicts and the change was > incorporated in the master differently, maybe a better way than my approach. > > I think we should change the way this is done because I would rather > receive feedback and change my PR than have the change on master done by > somebody else. Geronimo-openapi is a project with "1 Contributor" I was > trying to become the second one. > > Does this make sense? >
