Ok, I understand. But please avoid that, because it doesn't help new contributors to join the project.
Now that I am a father my kid helps me to better understand some new things. I bought a kid's broom for my daughter and the other day I was sweeping the house and she got the broom to help. She wasn't really helping at all, she was walking over the dust and spreading it... but she was there with me and at some point she will start to realize that and be able to help without making a mess. If I did it for her just because she is slow or doesn't bring the result it could be, she would probably never learn or help. I understand we are driven for results, but sometimes slowing down a bit and think the long term can be successful. Got a bit thoughtful here... hehehe but I think it helps us to think of how we can do better :) And btw, thanks for reaching out privately and offer a ticket for me to work on. That was nice of you! On Tue, Jan 8, 2019 at 4:19 PM Romain Manni-Bucau <[email protected]> wrote: > Hi Ivan > > Indeed it does but fix was quite straight forward and i was planning a > release on sunday - but got some "box" issues on saturday and a good part > of sunday so i didnt manage to make it. Rational was to include it in > microprofile repo release. If I can I will proceed later this week. > > On the process Im fine with whatever works the best and doesnt slow down > too much dependencies. Guess the fixes we got last week - and why mp repo > must be rereleased - + the fact it happens over a weekend for you was a no > luck case here. Also being more vocal on the dev list can help since we are > list driven and not github driven - just thinking out loud. At least it > would have enabled to 1. know you were going to work on that and 2. guide > you earlier and avoid to ask you to rework the pr probably. Wdyt? > > Romain > > > Le mar. 8 janv. 2019 18:56, Ivan Junckes Filho <[email protected]> a > écrit : > >> Hey Romain, I see your comments with feedback in the PR I opened, thank >> you for that. I had a busy weekend and couldn't reply immediately. >> https://github.com/apache/geronimo-openapi/pull/4 >> >> But I saw also in the PR that there were some conflicts and the change >> was incorporated in the master differently, maybe a better way than my >> approach. >> >> I think we should change the way this is done because I would rather >> receive feedback and change my PR than have the change on master done by >> somebody else. Geronimo-openapi is a project with "1 Contributor" I was >> trying to become the second one. >> >> Does this make sense? >> >
