[
https://issues.apache.org/jira/browse/GIRAPH-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396810#comment-13396810
]
Jakob Homan commented on GIRAPH-192:
------------------------------------
OK, this all sounds reasonable. We're being severely hobbled by a combination
of Java's type system and the Writable serialization format, leading to lots of
boilerplate code. But I don't see any easy way out of that right now.
The patch has a bunch of checkstyle errors (run mvn verify to get the list in
checkstyle-results.xml). After those are corrected and unit tests added, I
think we're good to go.
> Move aggregators to a seperate sub-package
> ------------------------------------------
>
> Key: GIRAPH-192
> URL: https://issues.apache.org/jira/browse/GIRAPH-192
> Project: Giraph
> Issue Type: Improvement
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Jan van der Lugt
> Assignee: Jan van der Lugt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: GIRAPH-192.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Since aggregators will be re-used throughout many projects and algorithms, it
> makes sense to implement the most common ones in a separate sub-package. This
> will reduce the time required for users when they implement their projects
> based on Giraph, because the required aggregators are already in place. I
> implemented the following ones:
> for int/long/float/double: min, max, product, sum, overwrite
> for boolean: and, or, overwrite
> Most of them speak for themselves, except for the overwrite one. This
> aggregator simply overwrites the stored value when a new value is aggregated.
> This is useful when one node is in some way a master node (for example a
> source node in an routing algorithm), and this node wants to broadcast a
> value to all other nodes.
> Attached is a patch against trunk implementing the aggregators and patching
> some existing files so they use the .aggregators package instead of the
> .examples one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
