[
https://issues.apache.org/jira/browse/GIRAPH-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397046#comment-13397046
]
Jakob Homan commented on GIRAPH-192:
------------------------------------
Looking good except it doesn't appear that the *AverageAggregators made it into
the latest patch. Unit tests look great. (there's an assert{True|False} if
you want to make some of the assertEquals simpler, but it's a matter of taste
and fine either way).
Assuming an overflow happens (which I think is a distinct possibility), it may
be best to just let it happen. I imagine it'll be a relatively common failure,
so it may be worth catching and failing gracefully, but that can be done in
another issue.
Except for the missing classes, this is ready to go.
> Move aggregators to a seperate sub-package
> ------------------------------------------
>
> Key: GIRAPH-192
> URL: https://issues.apache.org/jira/browse/GIRAPH-192
> Project: Giraph
> Issue Type: Improvement
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Jan van der Lugt
> Assignee: Jan van der Lugt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: GIRAPH-192.patch, GIRAPH-192.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Since aggregators will be re-used throughout many projects and algorithms, it
> makes sense to implement the most common ones in a separate sub-package. This
> will reduce the time required for users when they implement their projects
> based on Giraph, because the required aggregators are already in place. I
> implemented the following ones:
> for int/long/float/double: min, max, product, sum, overwrite
> for boolean: and, or, overwrite
> Most of them speak for themselves, except for the overwrite one. This
> aggregator simply overwrites the stored value when a new value is aggregated.
> This is useful when one node is in some way a master node (for example a
> source node in an routing algorithm), and this node wants to broadcast a
> value to all other nodes.
> Attached is a patch against trunk implementing the aggregators and patching
> some existing files so they use the .aggregators package instead of the
> .examples one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
