[ 
https://issues.apache.org/jira/browse/GIRAPH-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Presta updated GIRAPH-230:
-------------------------------------

    Attachment: GIRAPH-230.patch

This patch reorders all imports and updates checkstyle.xml and CODE_CONVENTIONS 
according to this template:

{code}
import org.apache.giraph.
import static org.apache.giraph.

import all other packages
import static all other packages

import java.
import javax.
import static java.
import static javax.
{code}

This is just an idea, and we can discuss a better ordering. This one was just 
really simple to come up with and enforce with Checkstyle.

                
> Uniform imports order
> ---------------------
>
>                 Key: GIRAPH-230
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-230
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-230.patch
>
>
> The order of imports currently varies from class to class.
> Enforcing a standard order can make our codebase more readable and let our 
> IDEs manage imports automatically without polluting diffs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to