Alessandro Presta created GIRAPH-240:
----------------------------------------

             Summary: Our vertices shouldn't accept null ids or values
                 Key: GIRAPH-240
                 URL: https://issues.apache.org/jira/browse/GIRAPH-240
             Project: Giraph
          Issue Type: Bug
          Components: graph
            Reporter: Alessandro Presta


I may be missing something, but I don't understand why HashMapVertex and 
EdgeListVertex (and possibly others) check for null vertexId and vertexValue 
instead of complaining.

Shouldn't each vertex be forced to have an id and a value? It's a source of 
potential bugs (see the serialization code that has to check for null and 
read/write a boolean flag) and I don't see the logic.
If one doesn't want vertex/edge values at all there's always NullWritable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to