[
https://issues.apache.org/jira/browse/GIRAPH-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409600#comment-13409600
]
Eli Reisman commented on GIRAPH-240:
------------------------------------
I do think that null vertex id's break Giraph on purpose, so maybe no need to
change that?
I also think your recent JIRA posts about optimizing the weighted and
unweighted graph's access methods are great. What about an overall JIRA to
simply optimize a base unweighted vertex and a base weighted vertex and then
all examples can explicitly be annotated for application developers to begin
with one of these (or if they choose, inherit from one of the examples that
inherits from one of these) I think there is a lot of great stuff here that
could be documented and simply made available to folks so none re-invents the
wheel by building their own vertex starting too far down the inheritance chain?
To some extent this is already supposed to be this way, but by implementing
your ideas we could make it explicit and document it for future users. Great
ideas!
> Our vertices shouldn't accept null ids or values
> ------------------------------------------------
>
> Key: GIRAPH-240
> URL: https://issues.apache.org/jira/browse/GIRAPH-240
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
>
> I may be missing something, but I don't understand why HashMapVertex and
> EdgeListVertex (and possibly others) check for null vertexId and vertexValue
> instead of complaining.
> Shouldn't each vertex be forced to have an id and a value? It's a source of
> potential bugs (see the serialization code that has to check for null and
> read/write a boolean flag) and I don't see the logic.
> If one doesn't want vertex/edge values at all there's always NullWritable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
