[
https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Reisman updated GIRAPH-209:
-------------------------------
Attachment: GIRAPH-209-5.patch
This version is a simpler solution, is up to date with changes in the codebase
and ready to commit. For various reasons, setting the -Dhadoop=... setting does
not seem to affect the build. by moving the hadoop.version from the default
props into the default profile (it already has a setting in each alternate
munge profile) you can now select any munge version at mvn command line with
-P<PROFILE_NAME> and I know it works because my mvn repo downloads the new jars
to build it. Now, no matter which profile you select when doing a build, the
giraph tar.gz and the jar with dependencies gets built with its old name +
"for-hadoop-${hadoop.version}" inserted, so you always know which version of
Hadoop to run it against. This is important because most of the profiles depend
on knowing that tidbit of data, knowing the mvn profile name is of little use
to new Giraph users who want to try a given Giraph build on their Hadoop
cluster and don't know if it is compatible or not. This has been tested with a
bunch of the profiles and builds fine. The only changes were a couple to the
pom.xml, assembly.xml and compile.xml
ready to commit, as far as I can see, please try this out and let me know what
you think.
> Include munge version in artifact name
> --------------------------------------
>
> Key: GIRAPH-209
> URL: https://issues.apache.org/jira/browse/GIRAPH-209
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Jakob Homan
> Assignee: Eli Reisman
> Priority: Blocker
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch,
> GIRAPH-209-5.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar
> and .tar.gz is just called giraph, meaning one can't know if one has the
> munged version one wants or even what one really has. The artifacts should
> include the munging identifier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
