[ 
https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-7.patch

This one works, renames all artifacts properly for all profiles, makes -P 
option work again instead of using -D to select build profile.

passes mvn verify, various profile builds.

Incidentally, there is an unrelated bug in the facebook build I have been 
having trouble with on trunk and still happens with this patch involving 
${hadoop.jar.path} POM variable. Is there a separate JIRA up on this or should 
I start one? I figured one of the FB folks would want to take a crack at this 
and I left it alone.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, 
> GIRAPH-209-5.patch, GIRAPH-209-6.patch, GIRAPH-209-7.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar 
> and .tar.gz is just called giraph, meaning one can't know if one has the 
> munged version one wants or even what one really has.  The artifacts should 
> include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to