[ 
https://issues.apache.org/jira/browse/GIRAPH-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418129#comment-13418129
 ] 

Eli Reisman commented on GIRAPH-26:
-----------------------------------

Great work Sean! Two suggestions:

1. Perhaps locking something this useful into PageRankBenchmark is too narrow; 
what if you generate the graph and simply let the output format dump it to disk 
in whatever data format the user chooses at the command line with -of. Then 
they can use it for whatever testing they want. Locking this into a single 
algorithm also keeps users from seeing the graph it generates, just the 
benchmark results.

2. Can't tell the line number from the diff, but there is a spot where it looks 
like you assign to a p1[0][0] four times in a row? did you mean p1[0][0] = ... 
then p1[0][1] = ... etc.?

                
> Improve PseudoRandomVertexInputFormat to create a more realistic synthetic 
> graph (e.g. power-law distributed vertex-cardinality).
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-26
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-26
>             Project: Giraph
>          Issue Type: Test
>          Components: benchmark
>    Affects Versions: 0.2.0
>            Reporter: Jake Mannix
>            Assignee: Sean Choi
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-26-1.patch
>
>
> The PageRankBenchmark class, to be a proper benchmark, should run over graphs 
> which look more like data seen in the wild, and web link graphs, social 
> network graphs, and text corpora (represented as a bipartite graph) all have 
> power-law distributions, so benchmarking a synthetic graph which looks more 
> like this would be a nice test which would stress cases of uneven 
> split-distribution and bottlenecks of subclusters of the graph of heavily 
> connected vertices.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to