[
https://issues.apache.org/jira/browse/GIRAPH-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430926#comment-13430926
]
Avery Ching commented on GIRAPH-291:
------------------------------------
Eli, this patch is not intended to replace GIRAPH-246. I believe that the main
contribution of GIRAPH-246 is to convert some waitForever() to waitMsecs() and
this is good. We should also do that part of GIRAPH-246. This patch is only
to address the issues I mentioned above.
1) Adds a test that proves that progress() is called multiple times in
waitForever() and keeps it verified for future changes.
2) Removes some complexity around the case where waitMsecs() could wait forever
(your work in GIRAPH-246).
> PredicateLock should have a constructor to take in a custom waiting time and
> additional testing
> -----------------------------------------------------------------------------------------------
>
> Key: GIRAPH-291
> URL: https://issues.apache.org/jira/browse/GIRAPH-291
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-291.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
