[
https://issues.apache.org/jira/browse/GIRAPH-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431306#comment-13431306
]
Jakob Homan commented on GIRAPH-291:
------------------------------------
Sleeps in tests are bad. Giraph has lots of time-based synchronization that
should be tested so we should invest now in making that easy. I would
recommend we -rip-off- pay homage to Voldemort's use of a [Time
interface|https://github.com/jghoman/voldemort/blob/83e2957a5d5ac9c924285819f5b099a86e0f1f4a/src/java/voldemort/utils/Time.java]
(with an example test
[here|https://github.com/jghoman/voldemort/blob/83e2957a5d5ac9c924285819f5b099a86e0f1f4a/test/unit/voldemort/store/stats/StatsTest.java]).
> PredicateLock should have a constructor to take in a custom waiting time and
> additional testing
> -----------------------------------------------------------------------------------------------
>
> Key: GIRAPH-291
> URL: https://issues.apache.org/jira/browse/GIRAPH-291
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-291.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
