----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6609/ -----------------------------------------------------------
Review request for giraph. Description ------- Same patch as https://issues.apache.org/jira/secure/attachment/12539928/GIRAPH-211.patch Current limitations: -Authorization is not done: that is, clients are authenticated but there are no restrictions on their ability to do RPC on the servers. -Clients should wait for authentication before trying to do RPC - once authorization (see above) is done, they might encounter a race where they try to do RPCs without yet being authenticated. -Not tested on other than hadoop 2.0.1-SNAPSHOT -Only works if we disable client-side channel-pooling (GIRAPH-289) and local short-circuiting of RPCs (GIRAPH-262) - these should be configurable but currently, I hard-wired both to be disabled. How to compile and test: mvn -Phadoop_2.0.1 clean test Works with the following test: $HADOOP_RUNTIME/bin/hadoop jar $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true -e 2 -s 10 -v -V 2 -w 2 This addresses bug GIRAPH-211. https://issues.apache.org/jira/browse/GIRAPH-211 Diffs ----- pom.xml c4ea04f src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java f103c7e src/main/java/org/apache/giraph/comm/ClientData.java PRE-CREATION src/main/java/org/apache/giraph/comm/CommunicationsInterface.java d60f512 src/main/java/org/apache/giraph/comm/NettyClient.java fe196df src/main/java/org/apache/giraph/comm/NettyServer.java 7a658fa src/main/java/org/apache/giraph/comm/NettyWorkerClient.java 40e5665 src/main/java/org/apache/giraph/comm/NettyWorkerServer.java 8c44f11 src/main/java/org/apache/giraph/comm/NullReply.java PRE-CREATION src/main/java/org/apache/giraph/comm/PeerMessage.java PRE-CREATION src/main/java/org/apache/giraph/comm/RPCCommunications.java 945a92e src/main/java/org/apache/giraph/comm/RequestDecoder.java cd930b2 src/main/java/org/apache/giraph/comm/RequestEncoder.java bdbd051 src/main/java/org/apache/giraph/comm/RequestRegistry.java 24307b3 src/main/java/org/apache/giraph/comm/RequestServerHandler.java eb851c3 src/main/java/org/apache/giraph/comm/ResponseClientHandler.java c64bf24 src/main/java/org/apache/giraph/comm/ResponseDecoder.java PRE-CREATION src/main/java/org/apache/giraph/comm/ResponseEncoder.java PRE-CREATION src/main/java/org/apache/giraph/comm/SaslComplete.java PRE-CREATION src/main/java/org/apache/giraph/comm/SaslNettyClient.java PRE-CREATION src/main/java/org/apache/giraph/comm/SaslNettyServer.java PRE-CREATION src/main/java/org/apache/giraph/comm/SaslTokenMessage.java PRE-CREATION src/main/java/org/apache/giraph/comm/SendMutationsCache.java b7c3022 src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java c6220fe src/main/java/org/apache/giraph/comm/SendPartitionMutationsRequest.java 1d31497 src/main/java/org/apache/giraph/comm/SendVertexRequest.java 657a90a src/main/java/org/apache/giraph/comm/ServerData.java c1eb737 src/main/java/org/apache/giraph/comm/WritableRequest.java 3c87d22 src/main/java/org/apache/giraph/comm/messages/SendPartitionCurrentMessagesRequest.java aaf73ee src/test/java/org/apache/giraph/comm/ConnectionTest.java b03f244 src/test/java/org/apache/giraph/comm/RequestTest.java 3b0635b Diff: https://reviews.apache.org/r/6609/diff/ Testing ------- Tested only on Hadoop 2.0.1-SNAPSHOT : needs testing on other Hadoops. Thanks, Eugene Koontz
