----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6609/ -----------------------------------------------------------
(Updated Aug. 29, 2012, 6:44 p.m.) Review request for giraph. Changes ------- I manually fixed some conflicts recently, so I'm gradually making this patch more closely fit to trunk. Fortunately, this patch is half the size of the last patch. Improvements: -Removes usage of RequestRegistry (that was removed in GIRAPH-313) Limitations: Uses preGIRAPH-313 workerThreadPool rather than requestServerHandlerFactory -Needs tests Description ------- Same patch as https://issues.apache.org/jira/secure/attachment/12539928/GIRAPH-211.patch Current limitations: -Authorization is not done: that is, clients are authenticated but there are no restrictions on their ability to do RPC on the servers. -Clients should wait for authentication before trying to do RPC - once authorization (see above) is done, they might encounter a race where they try to do RPCs without yet being authenticated. -Not tested on other than hadoop 2.0.1-SNAPSHOT -Only works if we disable client-side channel-pooling (GIRAPH-289) and local short-circuiting of RPCs (GIRAPH-262) - these should be configurable but currently, I hard-wired both to be disabled. How to compile and test: mvn -Phadoop_2.0.1 clean test Works with the following test: $HADOOP_RUNTIME/bin/hadoop jar $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true -e 2 -s 10 -v -V 2 -w 2 This addresses bug GIRAPH-211. https://issues.apache.org/jira/browse/GIRAPH-211 Diffs (updated) ----- src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java bc53b83 src/main/java/org/apache/giraph/comm/MasterRequestServerHandler.java 16e163a src/main/java/org/apache/giraph/comm/NettyClient.java 0353924 src/main/java/org/apache/giraph/comm/NettyServer.java 44a0043 src/main/java/org/apache/giraph/comm/NettyWorkerClient.java e5822e1 src/main/java/org/apache/giraph/comm/NettyWorkerClientServer.java 139e6f0 src/main/java/org/apache/giraph/comm/RequestServerHandler.java eae3f87 src/main/java/org/apache/giraph/comm/RequestType.java e363ad8 src/main/java/org/apache/giraph/comm/ResponseClientHandler.java 3adee8d src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java 4944894 src/main/java/org/apache/giraph/comm/SendPartitionMutationsRequest.java c39ba60 src/main/java/org/apache/giraph/comm/SendVertexRequest.java 014043d src/main/java/org/apache/giraph/comm/ServerData.java 68a2044 src/main/java/org/apache/giraph/comm/WorkerClient.java c3ec4fe src/main/java/org/apache/giraph/comm/WorkerRequestServerHandler.java ee4e286 src/main/java/org/apache/giraph/comm/WritableRequest.java 931feb7 src/main/java/org/apache/giraph/comm/messages/SendPartitionCurrentMessagesRequest.java b10e6e9 Diff: https://reviews.apache.org/r/6609/diff/ Testing ------- Tested only on Hadoop 2.0.1-SNAPSHOT : needs testing on other Hadoops. Thanks, Eugene Koontz
