[ 
https://issues.apache.org/jira/browse/GIRAPH-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maja Kabiljo updated GIRAPH-297:
--------------------------------

    Attachment: GIRAPH-297-fix.patch

This patch introduced a bug: with finalizing checkpoint I also moved the old 
superstep cleanup - my logic was that it's fine because of the new barrier. But 
barrier only happens in supersteps in which we do checkpointing. I am returning 
cleanup to its previous place. Unfortunately the bug was not discovered by any 
of our tests, since cleanup happens before it should only with one specific 
order of events.
                
> Checkpointing on master is done one superstep later
> ---------------------------------------------------
>
>                 Key: GIRAPH-297
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-297
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-297-1.patch, GIRAPH-297-fix.patch, 
> GIRAPH-297.patch
>
>
> On workers we store checkpoint X before compute() for superstep X are 
> executed. On master we do it after those compute() are executed and after 
> master.compute() for superstep X+1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to