> On Sept. 27, 2012, 6:40 p.m., Eugene Koontz wrote:
> > src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java, line 1310
> > <https://reviews.apache.org/r/6609/diff/6/?file=158675#file158675line1310>
> >
> >     Add:
> >     
> >     LOG.warn("You configured authentication at Giraph RPC level, but you 
> > are using Hadoop RPC to do Giraph RPC. Continuing with the assumption that 
> > your Hadoop is secure and not authenticating at Hadoop RPC level.");

Sorry, last part should read: "not authenticating at Giraph RPC level."


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6609/#review11988
-----------------------------------------------------------


On Sept. 20, 2012, 4:43 a.m., Eugene Koontz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6609/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2012, 4:43 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Current limitations:
> 
> -Not tested on other than hadoop trunk
> 
> How to use:
> 
> use 
> 
>   -Dgiraph.useNetty=true -Dgiraph.authenticate 
> 
> on your job's command line to use this feature.
> 
> How to compile and test:
> 
> mvn -Phadoop_trunk clean test
> 
> Works with the following test (after applying patch to trunk):
> 
> $HADOOP_RUNTIME/bin/hadoop jar 
> $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar
>  org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true 
> -Dgiraph.authenticate=true -e 2 -s 10 -v -V 2 -w 2
> 
> 
> This addresses bug GIRAPH-211.
>     https://issues.apache.org/jira/browse/GIRAPH-211
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java bc53b83 
>   src/main/java/org/apache/giraph/comm/WorkerClient.java c3ec4fe 
>   src/main/java/org/apache/giraph/comm/netty/NettyClient.java e6a8508 
>   src/main/java/org/apache/giraph/comm/netty/NettyServer.java 5904908 
>   src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 72e79a9 
>   src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientServer.java 
> b06e0f6 
>   src/main/java/org/apache/giraph/comm/netty/SaslNettyClient.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/netty/SaslNettyServer.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/netty/handler/Authorize.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/netty/handler/ResponseEncoder.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/netty/handler/SaslClientHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/requests/RequestType.java 4fbf692 
>   src/main/java/org/apache/giraph/comm/requests/SaslComplete.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/comm/requests/SaslTokenMessage.java 
> PRE-CREATION 
>   src/main/java/org/apache/giraph/graph/BspServiceWorker.java d926d1c 
>   src/main/java/org/apache/giraph/graph/GiraphJob.java 342be46 
> 
> Diff: https://reviews.apache.org/r/6609/diff/
> 
> 
> Testing
> -------
> 
> Tested only on Hadoop Trunk : needs testing on other Hadoops.
> 
> 
> Thanks,
> 
> Eugene Koontz
> 
>

Reply via email to