----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6609/ -----------------------------------------------------------
(Updated Oct. 10, 2012, 5:44 p.m.) Review request for giraph. Changes ------- Same patch as described in https://issues.apache.org/jira/browse/GIRAPH-211?focusedCommentId=13473381&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13473381 Description ------- Current limitations: -Not tested on other than hadoop trunk How to use: use -Dgiraph.useNetty=true -Dgiraph.authenticate=true on your job's command line to use this feature. How to compile and test: mvn -Phadoop_trunk clean test Works with the following test (after applying patch to trunk): $HADOOP_RUNTIME/bin/hadoop jar $GIRAPH_DIR/target/giraph-0.2-SNAPSHOT-for-hadoop-2.0.1-SNAPSHOT-jar-with-dependencies.jar org.apache.giraph.benchmark.PageRankBenchmark -Dgiraph.useNetty=true -Dgiraph.authenticate=true -e 2 -s 10 -v -V 2 -w 2 This addresses bug GIRAPH-211. https://issues.apache.org/jira/browse/GIRAPH-211 Diffs (updated) ----- pom.xml 51944fa src/main/java/org/apache/giraph/GiraphConfiguration.java 797ba6e src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1849504 src/main/java/org/apache/giraph/comm/CommunicationsInterface.java d60f512 src/main/java/org/apache/giraph/comm/SecureRPCCommunications.java af9720e src/main/java/org/apache/giraph/comm/WorkerClient.java c3ec4fe src/main/java/org/apache/giraph/comm/netty/NettyClient.java 93f5671 src/main/java/org/apache/giraph/comm/netty/NettyServer.java 886d68b src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 5b71401 src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientServer.java 4710f3a src/main/java/org/apache/giraph/comm/netty/SaslNettyClient.java PRE-CREATION src/main/java/org/apache/giraph/comm/netty/SaslNettyServer.java PRE-CREATION src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java 3174447 src/main/java/org/apache/giraph/comm/netty/handler/SaslClientHandler.java PRE-CREATION src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java PRE-CREATION src/main/java/org/apache/giraph/comm/requests/RequestType.java b412aa2 src/main/java/org/apache/giraph/comm/requests/SaslCompleteRequest.java PRE-CREATION src/main/java/org/apache/giraph/comm/requests/SaslTokenMessageRequest.java PRE-CREATION src/main/java/org/apache/giraph/graph/BspServiceWorker.java bb498ce src/test/java/org/apache/giraph/comm/SaslConnectionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/6609/diff/ Testing ------- Tested only on Hadoop Trunk : needs testing on other Hadoops. Thanks, Eugene Koontz
