[
https://issues.apache.org/jira/browse/GIRAPH-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510715#comment-13510715
]
Avery Ching commented on GIRAPH-443:
------------------------------------
This is an awesome improvement. A few comments:
1) Can you put up a reviewboard request?
2) When we use a direct buffer, we are not allowed to resize, so a mistake
would cause an IndexOutOfBoundsException exception. Could we specifically
catch that exception and report an error that makes sense (i.e. This error
likely indicates that the request size was not properly specified (see
getSerializedSize())
3) Not in this patch, but later on, we can also estimate the ByteArrayPartition
size fairly well. Would be great to pass on this improvement there as well.
> Properly size netty buffers when encoding requests
> --------------------------------------------------
>
> Key: GIRAPH-443
> URL: https://issues.apache.org/jira/browse/GIRAPH-443
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-443.patch
>
>
> For some type of requests, it's easy to calculate the exact size of requests,
> and create the buffers as big as we need.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
