[
https://issues.apache.org/jira/browse/GIRAPH-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568533#comment-13568533
]
Claudio Martella commented on GIRAPH-493:
-----------------------------------------
I'm with Alessandro on this one. Again, I think there are so many places we
create objects "for no reason", as Nitay pointed out in this patch, so I'm +1
on the approach. And, again, this is the time to break things, than later.
But this is the kind of change that is only measurable through benchmarking.
> Remove EdgeWithSource
> ---------------------
>
> Key: GIRAPH-493
> URL: https://issues.apache.org/jira/browse/GIRAPH-493
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Attachments: GIRAPH-493.patch
>
>
> We create a lot of EdgeWithSource (one per edge read) only to grab the
> sourceID / Edge out of them right after. Since we are not actually keeping
> these objects around we might as well just make the interface getSourceId()
> and getEdge() instead of the current get edge with source, and save on
> creating all of these objects.
> https://reviews.apache.org/r/9162/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
