[ 
https://issues.apache.org/jira/browse/GIRAPH-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571857#comment-13571857
 ] 

Hudson commented on GIRAPH-493:
-------------------------------

Integrated in Giraph-trunk-Commit #670 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/670/])
    GIRAPH-493: Remove EdgeWithSource (nitay) (Revision 
01b353334417fe9d511c239d013dedd822c8235a)

     Result = SUCCESS
nitay : 
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=01b353334417fe9d511c239d013dedd822c8235a
Files : 
* 
giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeWithSource.java
* giraph-core/src/main/java/org/apache/giraph/io/EdgeReader.java
* 
giraph-core/src/main/java/org/apache/giraph/io/formats/TextEdgeInputFormat.java
* CHANGELOG
* 
giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomEdgeInputFormat.java
* 
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogEdgeInputFormat.java

                
> Remove EdgeWithSource
> ---------------------
>
>                 Key: GIRAPH-493
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-493
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-493-2.patch, GIRAPH-493.patch
>
>
> We create a lot of EdgeWithSource (one per edge read) only to grab the 
> sourceID / Edge out of them right after. Since we are not actually keeping 
> these objects around we might as well just make the interface getSourceId() 
> and getEdge() instead of the current get edge with source, and save on 
> creating all of these objects.
> https://reviews.apache.org/r/9162/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to