----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/ -----------------------------------------------------------
Review request for giraph. Description ------- Refactor CLI parsing of args and the assembly of the GiraphConfiguration into its own class so that other future Runner classes besides GiraphRunner can use it w/o duplication. You get the idea. Diffs ----- giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java b6a6113 giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java fb4e8a3 giraph-core/src/main/java/org/apache/giraph/utils/CliParserUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/9350/diff/ Testing ------- Thanks, Eli Reisman
