> On Feb. 7, 2013, 4:14 a.m., Nitay Joffe wrote: > > giraph-core/src/main/java/org/apache/giraph/utils/CliParserUtils.java, line > > 174 > > <https://reviews.apache.org/r/9350/diff/1/?file=256471#file256471line174> > > > > We have similar-ish code in HiveGiraphRunner -hiveconf parameter, can > > we consolidate somehow? (possibly separate task)
yes as a separate task. I think after this is committed, consolidating the Runner classes will be an easy JIRA. - Eli ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/#review16249 ----------------------------------------------------------- On Feb. 8, 2013, 9:48 p.m., Eli Reisman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9350/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 9:48 p.m.) > > > Review request for giraph. > > > Description > ------- > > Refactor CLI parsing of args and the assembly of the GiraphConfiguration into > its own class so that other future Runner classes besides GiraphRunner can > use it w/o duplication. You get the idea. > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java b6a6113 > > giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java 9f711da > giraph-core/src/main/java/org/apache/giraph/job/GiraphTypeValidator.java > de2a66d > giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java > PRE-CREATION > giraph-core/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java > 80187ef > > Diff: https://reviews.apache.org/r/9350/diff/ > > > Testing > ------- > > > Thanks, > > Eli Reisman > >
