----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10052/#review18482 -----------------------------------------------------------
Please address these last few suggestions which you may have missed from the previous reviews. And yes, my dream is close to coming true! giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java <https://reviews.apache.org/r/10052/#comment38771> Why not return the same TestGraph instance instead? If TestGraph implements Iterable<Vertex> and has getVertex(i), that's basically all we need, and that way input and output talk the same class. giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java <https://reviews.apache.org/r/10052/#comment38770> You're not using "iterability" of TestGraph anywhere. If you make this an Iterable<Vertex> though, it can be pretty useful. giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java <https://reviews.apache.org/r/10052/#comment38765> Not sure why clear() needs to return this. What is the use case? giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java <https://reviews.apache.org/r/10052/#comment38768> You're not using this id iterator anywhere, so why not make this the vertex iterator instead? giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java <https://reviews.apache.org/r/10052/#comment38766> Again, why no generic types here? - Alessandro Presta On March 28, 2013, 10:19 p.m., Veselin Stoyanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10052/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 10:19 p.m.) > > > Review request for giraph. > > > Description > ------- > > A framework for running small test graphs in memory. > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > 4b03127f3490d35e6e3ddf7b69a9d0bc4673420d > giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java > PRE-CREATION > > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10052/diff/ > > > Testing > ------- > > > Thanks, > > Veselin Stoyanov > >
