----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10052/#review18520 -----------------------------------------------------------
Ship it! I'm still not sure why you need to include an id iterator, but I'm fine with this. Can you post an updated patch on the JIRA (create with "post-review -n > GIRAPH-577.patch"). Thanks! - Alessandro Presta On March 29, 2013, 5:56 p.m., Veselin Stoyanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10052/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 5:56 p.m.) > > > Review request for giraph. > > > Description > ------- > > A framework for running small test graphs in memory. > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > 4b03127f3490d35e6e3ddf7b69a9d0bc4673420d > giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java > PRE-CREATION > > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10052/diff/ > > > Testing > ------- > > > Thanks, > > Veselin Stoyanov > >
