[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628346#comment-13628346
]
Maja Kabiljo commented on GIRAPH-613:
-------------------------------------
I am not sure which patch you are referring to, and I wouldn't say that the
feature is currently broken, it just needs to be implemented in the Vertex
implementation (from readFields method). Maybe I am missing something, but I
don't see how it can be implemented from outside of giraph core with this
change. But sure, one of us can implement it, I think it's a really short
change and was trying to give you pointers about how to do it. Reusing Vertex
object is already there, we just need to reuse id, value and edges as well.
Moving these methods to WritableUtils sounds good.
I remember one of the checkpoint distributed tests was also broken, glad to
hear it's fixed :-)
> Remove Writable from the interfaces implemented by Vertex
> ---------------------------------------------------------
>
> Key: GIRAPH-613
> URL: https://issues.apache.org/jira/browse/GIRAPH-613
> Project: Giraph
> Issue Type: Improvement
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Minor
> Attachments: GIRAPH-613.diff, NonWritable.diff
>
>
> Currently, Vertex implements Writable, meaning that we depend on the user
> (except for the default implementation) on the way the graph is serialised
> and deserialized. This means we cannot do certain optimisations, and the user
> can actually add additional stuff to Vertex more than Value, Id, Edges and
> halt state. By removing this possibility (or allowing them to extend a
> default implementation) we take control of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
