[ 
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629117#comment-13629117
 ] 

Maja Kabiljo commented on GIRAPH-613:
-------------------------------------

Awesome, thanks! One question: where are the objects for id, value and edges of 
representativeVertex in ByteArrayParttion created? Don't we have to do 
something like:
{code} representativeVertex.initialize(getConf().createVertexId(), 
getConf().createVertexValue()); {code}

And I'd replace the 'checkpoint' word from Vertex javadoc with 'store' or 
something like that, because checkpoint is not the only thing which will break 
if user tries to use fields from Vertex (vertices are also serialized during 
input superstep, if ByteArrayPartition or out-of-core graph is used).

Other than that, +1.
                
> Remove Writable from the interfaces implemented by Vertex
> ---------------------------------------------------------
>
>                 Key: GIRAPH-613
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-613
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Minor
>         Attachments: GIRAPH-613.diff, GIRAPH-613.diff, NonWritable.diff
>
>
> Currently, Vertex implements Writable, meaning that we depend on the user 
> (except for the default implementation) on the way the graph is serialised 
> and deserialized. This means we cannot do certain optimisations, and the user 
> can actually add additional stuff to Vertex more than Value, Id, Edges and 
> halt state. By removing this possibility (or allowing them to extend a 
> default implementation) we take control of this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to