> On April 17, 2013, 5:11 p.m., Alessandro Presta wrote: > > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java, > > line 664 > > <https://reviews.apache.org/r/10564/diff/1-2/?file=281712#file281712line664> > > > > Isn't the VertexInputFormat also always the same? Looks like we should > > only be logging the HiveToVertex class and input description. > > Also, for uniformity with edge input formats, you may want to prepend > > the line "Vertex input format:".
As I said initially, I did everything just for edge input to get some feedback, once we agree on design I'll go ahead and make changes for vertex input too. > On April 17, 2013, 5:11 p.m., Alessandro Presta wrote: > > giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstants.java, > > line 47 > > <https://reviews.apache.org/r/10564/diff/1/?file=281713#file281713line47> > > > > Shouldn't this be "classes" too? This is going to be used as: giraph.hive.to.edge.class.0 giraph.hive.to.edge.class.1 and so on, so I think this name is fine. - Maja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10564/#review19322 ----------------------------------------------------------- On April 17, 2013, 4:19 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10564/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 4:19 a.m.) > > > Review request for giraph. > > > Description > ------- > > For now, I did this only for Edge input, once I get some feedback I'll do the > exactly same thing for vertex input. > Also, I added direct support only to HiveGiraphRunner, we can extend it later > to others as well. > > > This addresses bug GIRAPH-639. > https://issues.apache.org/jira/browse/GIRAPH-639 > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 178c96f > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 4a0e8f7 > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > 7f9e38e > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > 6a5949e > > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java > 8dfe546 > giraph-core/src/main/java/org/apache/giraph/io/InputFormatWithIndex.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java > cc6b126 > giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java > d01dbb4 > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > 029cb5d > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java > 037cdfc > > giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java > afb636b > > giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java > 4a1705b > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java > 6e40b7f > > giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstants.java > f8363b1 > giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveProfiles.java > 892d443 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInputFormat.java > c482cf0 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java > 09476cd > > Diff: https://reviews.apache.org/r/10564/diff/ > > > Testing > ------- > > mvn clean verify > Run application with two edge input tables - verified results. > > > Thanks, > > Maja Kabiljo > >
