-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10564/
-----------------------------------------------------------

(Updated April 30, 2013, 7:05 a.m.)


Review request for giraph.


Changes
-------

Updated per offline discussion with Alessandro - instead of having 
infrastructure handle several input formats, we can create special input format 
which wraps several input formats. Some things from the infrastructure needed 
to be changed in order to make this work, like moving the read/write InputSplit 
functionality to input formats. The regular use case is now unchanged, 
HiveGiraphRunner has direct support for several input formats.


Description
-------

For now, I did this only for Edge input, once I get some feedback I'll do the 
exactly same thing for vertex input.
Also, I added direct support only to HiveGiraphRunner, we can extend it later 
to others as well.


This addresses bug GIRAPH-639.
    https://issues.apache.org/jira/browse/GIRAPH-639


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 
795cd0c 
  
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
 f5a926f 
  giraph-core/src/main/java/org/apache/giraph/io/EdgeInputFormat.java 2aac1f0 
  giraph-core/src/main/java/org/apache/giraph/io/GiraphInputFormat.java 13efc93 
  giraph-core/src/main/java/org/apache/giraph/io/VertexInputFormat.java c4d7fe2 
  
giraph-core/src/main/java/org/apache/giraph/io/formats/multi/EdgeInputFormatDescription.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/io/formats/multi/InputFormatDescription.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/io/formats/multi/MultiEdgeInputFormat.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/io/formats/multi/package-info.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java
 9b14727 
  giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 
2c1a679 
  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 
01937ab 
  
giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java 
de1e774 
  
giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java
 4a1705b 
  giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java 
a3a9ab7 
  
giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
 224856e 
  
giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallableFactory.java
 4eff3b8 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 
8d67c1d 

Diff: https://reviews.apache.org/r/10564/diff/


Testing
-------

mvn clean verify
Run application with two edge input tables - verified results.


Thanks,

Maja Kabiljo

Reply via email to