-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12291/
-----------------------------------------------------------

(Updated July 7, 2013, 6:18 a.m.)


Review request for giraph.


Summary (updated)
-----------------

GIRAPH-708: Factories for all user types


Bugs: GIRAPH-708
    https://issues.apache.org/jira/browse/GIRAPH-708


Repository: giraph-git


Description
-------

Factories for creation of all IVEM types


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java 
40023c212dc44ad5e377867a97f808eb203c11c4 
  giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java 
affc260180bdae8d699dc3e01c117239d56df3c0 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java
 fecd7eed38ab6dff3c8b0087f4a3af8f62ed0364 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java
 ba8a005905eba8cd85fc720ba8b3b4b6ddc4eb10 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreFactory.java
 aa6a63efe01f01276432b5d7913026e709c5583f 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessagesIterable.java 
970d76d2baafe13ef140e16911ffab9697abf68e 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
 f18af5bccff5e16c4eb47eefdf9bb63fa43d85d0 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java
 c9d869c13fef375a02a9e59d48bda3dbb3b202f3 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/DiskBackedMessageStore.java
 1cda1d9bee371220b434665adbb46065317e3af7 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/PartitionDiskBackedMessageStore.java
 4ae805a47e24acb97641e6d5c6fb45a0470e9985 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/SequentialFileMessageStore.java
 e5931c6ece028e2c1bf29e44d16caddf2a259771 
  
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
 d786db506b645736b928f94b0a623818b0ade1ba 
  
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
 88641c5b25a138736a06158ef6be2fa60cab0021 
  
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java
 f6bf9bf79ccb251427acb44088004847f576f48d 
  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 
af82df517bec495b9852b8774103242e3ba2cec9 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 
f039bdcfa730c566551ab11d8951a2cf3b6a219b 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 
2d232a6ac7527d114d4cdb9c80a68799f18f59da 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 
c65b5f04f0590d2777056a0b8022584682ce5ca6 
  
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
 64d0fb2f49cf8f149ac230061bb0d9fda12c83e5 
  
giraph-core/src/main/java/org/apache/giraph/factories/AbstractMessageValueFactory.java
 PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/ComputationFactory.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultComputationFactory.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultEdgeValueFactory.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultIncomingMessageValueFactory.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultOutgoingMessageValueFactory.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultVertexIdFactory.java
 PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/DefaultVertexValueFactory.java
 PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/EdgeValueFactory.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/MessageValueFactory.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/factories/TestMessageValueFactory.java
 PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/ValueFactories.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/VertexIdFactory.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/VertexValueFactory.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/factories/package-info.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java 
d23db05ad934ebb73f88d4eaecffc4fe3c45bc99 
  
giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java
 405b27264014509fa52d1b8207fac12b91954016 
  
giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertexValueFactory.java
 adbe9d335dd728e53f36db7e0dd36662258d41bb 
  giraph-core/src/main/java/org/apache/giraph/graph/VertexValueFactory.java 
eb9197cb016b6620925f7be84a7bf95abe5b82b4 
  
giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java
 486c6db40a3d4b3053850e4f76f1efde20163bdc 
  
giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
 f7331acc99909e665fae869a5fdb31d82b0a6e5c 
  
giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayVertexIdMessages.java
 6b4642c7f31dd39116ac5114764c68ff7672c12d 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 
f0a7e4f784f970250f6f515a261b19f15e18fbc7 
  giraph-core/src/main/java/org/apache/giraph/utils/WritableUtils.java 
c78d717fd1f1e91d2c07c6455ae671fba6516e82 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java 
35e63623248db6c99a4fe0e20867dd36c6403d14 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java 
c8c09df4bf998323f7b0b84727defd50b7560477 
  giraph-core/src/test/java/org/apache/giraph/comm/TestMessageStores.java 
e270816ad77596549f01cd1e3ff4e7897b4a53c4 
  giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 
327aaa3deebe83981bc7093e1ede7447e8cb51ea 
  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java 
c9b4ace07a2be085e4b5480427815f4cb1a4565e 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 
0e3503c970b93f288b61b143736744d27876558d 
  
giraph-examples/src/test/java/org/apache/giraph/vertex/TestComputationTypes.java
 3c63ee04e792456230a37c500332216456e56587 

Diff: https://reviews.apache.org/r/12291/diff/


Testing
-------


Thanks,

Nitay Joffe

Reply via email to