> On July 9, 2013, 12:28 a.m., Maja Kabiljo wrote: > > giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreFactory.java, > > line 40 > > <https://reviews.apache.org/r/12291/diff/3/?file=318949#file318949line40> > > > > Do we still need messageClass here? > > Nitay Joffe wrote: > Originally I didn't have it but your latest diff for in-memory message > stores that checks the message class at runtime now requires it. > > Maja Kabiljo wrote: > Can't we get message class from the factory? > > Nitay Joffe wrote: > We would have to pass it in to each one and store it in the factory > itself. > Or we would have to store the ICGC and get it out of there. > What do you think?
Factory already knows which message class it's using. We can just add the method which exposes the message class to the factory and call that wherever we are currently using messageClass? - Maja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12291/#review22841 ----------------------------------------------------------- On July 9, 2013, 1:53 a.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12291/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 1:53 a.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-708 > https://issues.apache.org/jira/browse/GIRAPH-708 > > > Repository: giraph-git > > > Description > ------- > > Factories for creation of all IVEM types > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java > 40023c212dc44ad5e377867a97f808eb203c11c4 > giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java > 6dd716ac8621dd46215f3e32f394521cdee44502 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java > 16001f3c30eeb1d40ea434928ebb8da76c827995 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java > 966f29ee065570a1051fbdd0e9a175bf4c312e29 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreFactory.java > aa6a63efe01f01276432b5d7913026e709c5583f > > giraph-core/src/main/java/org/apache/giraph/comm/messages/MessagesIterable.java > 970d76d2baafe13ef140e16911ffab9697abf68e > > giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java > f18af5bccff5e16c4eb47eefdf9bb63fa43d85d0 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java > c9d869c13fef375a02a9e59d48bda3dbb3b202f3 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/DiskBackedMessageStore.java > 1cda1d9bee371220b434665adbb46065317e3af7 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/PartitionDiskBackedMessageStore.java > 0a96b0548d8d6d2555f6d8c123de0eb0457585e8 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/SequentialFileMessageStore.java > e5931c6ece028e2c1bf29e44d16caddf2a259771 > > giraph-core/src/main/java/org/apache/giraph/comm/messages/primitives/IntByteArrayMessageStore.java > ed11e33a03729f3bacdef920cf1feb0ea42e402d > > giraph-core/src/main/java/org/apache/giraph/comm/messages/primitives/LongByteArrayMessageStore.java > f25972e16952dd010a46d461db290b61a5b66280 > > giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java > d786db506b645736b928f94b0a623818b0ade1ba > > giraph-core/src/main/java/org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java > 88641c5b25a138736a06158ef6be2fa60cab0021 > > giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java > f6bf9bf79ccb251427acb44088004847f576f48d > giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java > af82df517bec495b9852b8774103242e3ba2cec9 > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java > f039bdcfa730c566551ab11d8951a2cf3b6a219b > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > 2d232a6ac7527d114d4cdb9c80a68799f18f59da > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > c65b5f04f0590d2777056a0b8022584682ce5ca6 > > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java > 64d0fb2f49cf8f149ac230061bb0d9fda12c83e5 > > giraph-core/src/main/java/org/apache/giraph/factories/AbstractMessageValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/ComputationFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultComputationFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultEdgeValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultIncomingMessageValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultOutgoingMessageValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultVertexIdFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/DefaultVertexValueFactory.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/factories/EdgeValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/MessageValueFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/TestMessageValueFactory.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/factories/ValueFactories.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/factories/ValueFactoryBase.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/factories/VertexIdFactory.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/factories/VertexValueFactory.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/factories/package-info.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java > d23db05ad934ebb73f88d4eaecffc4fe3c45bc99 > > giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java > 405b27264014509fa52d1b8207fac12b91954016 > > giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertexValueFactory.java > adbe9d335dd728e53f36db7e0dd36662258d41bb > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java > e7af82565f38fbaafd06b4579acd4dce48e6f027 > giraph-core/src/main/java/org/apache/giraph/graph/VertexValueFactory.java > eb9197cb016b6620925f7be84a7bf95abe5b82b4 > > giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java > 486c6db40a3d4b3053850e4f76f1efde20163bdc > > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java > f7331acc99909e665fae869a5fdb31d82b0a6e5c > > giraph-core/src/main/java/org/apache/giraph/utils/ByteArrayVertexIdMessages.java > 6b4642c7f31dd39116ac5114764c68ff7672c12d > giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java > aba51318b052693440ccb6131ae7bb3120bdac96 > giraph-core/src/main/java/org/apache/giraph/utils/WritableUtils.java > 695b08d0bd47bfbcec02267e6acc3d40868630d4 > giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java > c2c85682bb30625c4d0bf54a7029ee433abf524d > giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java > d7664efdaca2d17669821365dabeaa2cc70faf11 > giraph-core/src/test/java/org/apache/giraph/comm/TestMessageStores.java > e270816ad77596549f01cd1e3ff4e7897b4a53c4 > > giraph-core/src/test/java/org/apache/giraph/comm/messages/TestIntFloatPrimitiveMessageStores.java > fd3a4967d7632f9c0b35ce0d74bfebdfec2cf936 > > giraph-core/src/test/java/org/apache/giraph/comm/messages/TestLongDoublePrimitiveMessageStores.java > 5a690629b278714a45af1dd3badbce8fcbfeefef > giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java > 327aaa3deebe83981bc7093e1ede7447e8cb51ea > giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java > c9b4ace07a2be085e4b5480427815f4cb1a4565e > giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java > 0e3503c970b93f288b61b143736744d27876558d > > giraph-examples/src/test/java/org/apache/giraph/vertex/TestComputationTypes.java > 3c63ee04e792456230a37c500332216456e56587 > > Diff: https://reviews.apache.org/r/12291/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
