[ 
https://issues.apache.org/jira/browse/GIRAPH-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422871#comment-16422871
 ] 

ASF GitHub Bot commented on GIRAPH-1181:
----------------------------------------

Github user yukselakinci commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/65#discussion_r178604012
  
    --- Diff: 
giraph-core/src/main/java/org/apache/giraph/utils/ExtendedInput.java ---
    @@ -0,0 +1,326 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.giraph.utils;
    +
    +import com.esotericsoftware.kryo.KryoException;
    +import com.esotericsoftware.kryo.io.Input;
    +import java.io.IOException;
    +import java.io.UTFDataFormatException;
    +import java.lang.reflect.Field;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_LONG;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_BOOLEAN;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_BYTE;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_CHAR;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_SHORT;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_INT;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_FLOAT;
    +import static org.apache.giraph.utils.ByteUtils.SIZE_OF_DOUBLE;
    +
    +/**
    + * ExtendedInput allows kryo to read directly from the underlying stream
    + * without having to write to an interim buffer.
    + */
    +public class ExtendedInput extends Input implements ExtendedDataInput {
    --- End diff --
    
    Done. 


> Changes to ExtendedByteArrayDataOutput
> --------------------------------------
>
>                 Key: GIRAPH-1181
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1181
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>            Priority: Major
>
> Adding a new stream type which extends from 
> com.esotericsoftware.kryo.io.Input/Output, so that it can be used with kryo 
> serializer. It improves the performance of kryo by faster read/writes (unsafe 
> IO), and also eliminates the need for interim buffers to convert from 
> DataInput and DataOutput.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to