[ 
https://issues.apache.org/jira/browse/GIRAPH-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422874#comment-16422874
 ] 

ASF GitHub Bot commented on GIRAPH-1181:
----------------------------------------

Github user yukselakinci commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/65#discussion_r178604190
  
    --- Diff: 
giraph-core/src/main/java/org/apache/giraph/partition/ByteArrayPartition.java 
---
    @@ -233,14 +232,8 @@ public void write(DataOutput output) throws 
IOException {
           entry.getKey().write(output);
           // Note here that we are writing the size of the vertex data first
           // as it is encoded in the first four bytes of the byte[]
    -      int vertexDataSize;
    -      if (useUnsafeSerialization) {
    --- End diff --
    
    I have added back the non-unsafe version


> Changes to ExtendedByteArrayDataOutput
> --------------------------------------
>
>                 Key: GIRAPH-1181
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1181
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>            Priority: Major
>
> Adding a new stream type which extends from 
> com.esotericsoftware.kryo.io.Input/Output, so that it can be used with kryo 
> serializer. It improves the performance of kryo by faster read/writes (unsafe 
> IO), and also eliminates the need for interim buffers to convert from 
> DataInput and DataOutput.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to