[ 
https://issues.apache.org/jira/browse/GIRAPH-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430757#comment-16430757
 ] 

ASF GitHub Bot commented on GIRAPH-1185:
----------------------------------------

Github user majakabiljo commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/69#discussion_r180140140
  
    --- Diff: 
giraph-core/src/main/java/org/apache/giraph/writable/kryo/HadoopKryo.java ---
    @@ -203,15 +277,33 @@ public T execute(Kryo kryo) {
         });
       }
     
    +  /**
    +   * Returns a kryo which doesn't track objects, hence
    +   * no recursive/nested objects should be serialized.
    +   * @return Hadoop kryo which doesn't track objects.
    +   */
    +  public static HadoopKryo getNontrackingKryo() {
    --- End diff --
    
    How will someone using kryo know which implementation to use? Can we add 
some guidance around that?


> Adding faster serialization classes.
> ------------------------------------
>
>                 Key: GIRAPH-1185
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1185
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>            Priority: Major
>
> These changes add two new kryo serialization classes (KryoSimpleWritable and 
> KryoSimpleWrapper) which disable reference tracking at the expense of not 
> supporting recursive and nested structures. Disabling reference tracking 
> significantly improves the serialization performance. One a sample pipeline, 
> the running time reduced from 75 minutes to 5 minutes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to