[ 
https://issues.apache.org/jira/browse/GIRAPH-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433128#comment-16433128
 ] 

ASF GitHub Bot commented on GIRAPH-1185:
----------------------------------------

Github user yukselakinci commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/69#discussion_r180591634
  
    --- Diff: 
giraph-core/src/main/java/org/apache/giraph/writable/kryo/HadoopKryo.java ---
    @@ -111,19 +123,15 @@ public Kryo create() {
             "Logger must be a static field");
       }
     
    -  // Use chunked streams, so within same stream we can use both kryo and
    -  // non-kryo serialization.
       /** Reusable Input object */
    -  private final InputChunked input = new InputChunked(4096);
    +  private InputChunked input;
    --- End diff --
    
    Agreed, we can refactor the existing code to have a better code 
readability. I have added a TODO for that.


> Adding faster serialization classes.
> ------------------------------------
>
>                 Key: GIRAPH-1185
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1185
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>            Priority: Major
>
> These changes add two new kryo serialization classes (KryoSimpleWritable and 
> KryoSimpleWrapper) which disable reference tracking at the expense of not 
> supporting recursive and nested structures. Disabling reference tracking 
> significantly improves the serialization performance. One a sample pipeline, 
> the running time reduced from 75 minutes to 5 minutes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to